added slimmenu for mobile, also revised general responsive layouts: Issue #39

[JuanGongora]

Note: The majority of the files come from adding the cog templates 'block' and 'navigation' over to the lightup theme, the rest are from adding the new module Asset Injector, and the slimmenu package. Aside from that only minor snippets of code were edited in scss and twig files, which are described in the numbered notes from the commit. So overall it's not the massive amount of added or deleted files you may think at first sight. ;)

Update: had to insert snippet that was not pushed from the asset injector module in new commit.

In order to see the changes make sure to run gulp compile:sass, and then clear the cache.

Other issues this pull resolves:

#22

#34

[rick02840]

Hi Juan,
So sorry it took me forever to look at this.
Possibly a better way to do this is with this module: https://www.drupal.org/project/responsive_menu
Let's discuss tonight.
I created a fresh branch to work on this: 39_hamburger_menu
Also, note I updated Drupal core to 8.4.6 so when you download the latest code you will need to either run drush updb or go to /update.php and run database updates there.
Thanks,
Rick

[JuanGongora]

Hi Rick! No problem! I wanted to review the pull with you anyways to make sure that I had everything right so no worries haha. Looking forward to talking with you at H4M meetup! Kind regards, Juan

…

On Tue, Apr 17, 2018 at 6:57 AM, Rick Hood ***@***.***> wrote: Hi Juan, So sorry it took me forever to look at this. Possibly a better way to do this is with this module: https://www.drupal.org/project/responsive_menu Let's discuss tonight. I created a fresh branch to work on this: 39_hamburger_menu Also, note I updated Drupal core to 8.4.6 so when you download the latest code you will need to either run drush updb or go to /update.php and run database updates there. Thanks, Rick — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALgGJsbc9JooQSj_wmcC8b0bxrt909laks5tpcq0gaJpZM4SVpCO> .