Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot show 🎵 in slide mode #360

Closed
terric912 opened this issue Feb 16, 2017 · 2 comments
Closed

cannot show 🎵 in slide mode #360

terric912 opened this issue Feb 16, 2017 · 2 comments
Labels
bug Something isn't working upstream This issue belongs to a library or component outside

Comments

@terric912
Copy link

Cannot show 🎵 in slide mode, it shows :musical_ only.
@jackycute
Copy link
Member

jackycute commented Feb 16, 2017 •
edited
Loading

Yeah, this seems like regex issue from speaker note plugin in the slide mode upstream (reveal.js)
https://github.com/hakimel/reveal.js/blob/master/plugin/notes/notes.js#L119

We could make a fix then PR back.

@a60814billy a60814billy added the upstream This issue belongs to a library or component outside label Feb 16, 2017
@jackycute jackycute added the bug Something isn't working label Feb 27, 2017
@jackycute jackycute mentioned this issue Apr 26, 2017
Closed
@jackycute
Copy link
Member

Fixed in 48f8378

jackycute added a commit to hackmdio/reveal.js that referenced this issue Jun 4, 2017
@jackycute
Fix speaker note separator regex
b7bd8d2 
it should only take effect on the line start
related: hackmdio/codimd#360
@jackycute jackycute mentioned this issue Jun 4, 2017
Closed
LongLiveCHIEF pushed a commit to HackerHappyHour/reveal that referenced this issue Apr 26, 2019
@jackycute @LongLiveCHIEF
Fix speaker note separator regex
834a9f1 
it should only take effect on the line start
related: hackmdio/codimd#360
@LongLiveCHIEF LongLiveCHIEF mentioned this issue Apr 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream This issue belongs to a library or component outside
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@a60814billy @jackycute @terric912