-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add messages for exceptions #245
base: experimental
Are you sure you want to change the base?
Conversation
Revert "Enable to choose a camera device in UI" Will put it on experimental as of this moment
… install requirements. Now the code is working. You are able to run it on your Windows machine.
Fix this cyclic dependency issue which was coming while installing rquirements
Fixed a typo.
Update README.md
relinking this to the old repo
Reviewer's Guide by SourceryThis pull request makes several changes to improve error handling, simplify the webcam preview functionality, update the README, and modify the UI. The main focus is on adding error messages for FFmpeg-related exceptions and simplifying the camera selection process. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ZillaRU - I've reviewed your changes - here's some feedback:
Overall Comments:
- The removal of the camera selection feature reduces functionality. Consider keeping this feature or providing a justification for its removal.
- Error handling for webcam initialization has been removed from the
webcam_preview
function. Please add appropriate error checking to ensure robust behavior. - In the README, consider moving the credit for the original author (s0md3v) to the main credits section rather than a footnote for proper acknowledgement.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
- [ffmpeg](https://ffmpeg.org/): for making video related operations easy | ||
- [deepinsight](https://github.com/deepinsight): for their [insightface](https://github.com/deepinsight/insightface) project which provided a well-made library and models. | ||
- [havok2-htwo](https://github.com/havok2-htwo) : for sharing the code for webcam | ||
- [GosuDRM](https://github.com/GosuDRM/nsfw-roop) : for uncensoring roop | ||
- and all developers behind libraries used in this project. | ||
- and [all developers](https://github.com/hacksider/Deep-Live-Cam/graphs/contributors) behind libraries used in this project. | ||
- Foot Note: [This is originally roop-cam, see the full history of the code here.](https://github.com/hacksider/roop-cam) Please be informed that the base author of the code is [s0md3v](https://github.com/s0md3v/roop) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (documentation): Change 'Foot Note' to 'Footnote'.
Bug: For many devices holding a customized version of FFmpeg, the commands in
run_ffmpeg
anddetect_fps
might fail to be executed in silence.Solution: Add some info messages to the two functions.
Summary by Sourcery
Enhance error handling in
run_ffmpeg
anddetect_fps
functions by adding informative messages. Update README.md with minor corrections and additional information about the experimental branch. Clean up unused camera selection code in the UI module.Enhancements:
run_ffmpeg
anddetect_fps
functions to notify users when commands fail.Documentation:
Chores:
create_root
andwebcam_preview
functions inmodules/ui.py
.