vaultfs: Support K/V v2 secret engine #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
This adds support for the K/V v2 secrets mounts. It can be used in exactly the same way that K/V v1 mounts are used (same URL scheme, etc). The one difference is that a
?version=query parameter can be sent to request previous secret versions.In this implementation, a check is made prior to accessing the mount to find out what version of the
kvengine is in use. Currently this is done on every access, doubling the number of requests. In future it may be useful to add some caching to improve performance - however because it is possible to upgrade a kv-v1 mount to kv-v2 at runtime, this will be a bit more complex to get right.Signed-off-by: Dave Henderson [email protected]