Support git repos with default branches other than "master" #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
git-use-correct-default-branch-1049
branch
from
f4a7e36 to
c14539e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1049
This is a workaround for go-git/go-git#249, as suggested in go-git/go-git#249 (comment).
Ideally
go-gitwould do this for me, but for now this is the best option.I've altered the tests so that one of the test repos has a default branch of
main, to verify the behaviour.If for some reason the remote's branch can't be determined, the error will be logged but the datasource will continue to defer to
go-git's default.Signed-off-by: Dave Henderson [email protected]