Fix merging context/datasources config #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @paddycarey! |
hairyhenderson
force-pushed
the
fix-merge-config
branch
from
df41c0c to
7d39797
Compare
paddycarey
force-pushed
the
fix-merge-config
branch
from
7d39797 to
06341cd
Compare
|
Sorry for the delay - been having some CI trouble 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes config merging when context/datasources are provided on the command line but not in the config file.
When a config file is used which doesn't contain
contextordatasourceskeys, those values are parsed asnil. Then whenconfig.Config.MergeFromis called (and subsequentlyconfig.mergeDataSources) the application panics as it's trying to write to a nil map.