Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ppc64le support #1440

Merged
merged 2 commits into from
Jun 26, 2022
Merged

Conversation

mayurwaghmode
Copy link
Contributor

This PR will add ppc64le support to the gomplate image.

@mayurwaghmode
Copy link
Contributor Author

@hairyhenderson can u please review the PR?

@hairyhenderson
Copy link
Owner

Thanks for the PR @mayurwaghmode. I will consider this. Can you clarify what the use-case is for ppc64le?

@mayurwaghmode
Copy link
Contributor Author

Thank you @hairyhenderson for considering the PR. We need the ppc64le supported release binary of gomplate tool for building the https://github.com/dexidp/dex package.

@mayurwaghmode
Copy link
Contributor Author

@hairyhenderson can u please take a look at this PR?

@hairyhenderson
Copy link
Owner

@mayurwaghmode It's on my list - I haven't forgotten. Please continue to be patient and I will get to it when I have time.

@hairyhenderson
Copy link
Owner

I've found time to test this out, and it looks like it works - thanks @mayurwaghmode

@hairyhenderson hairyhenderson enabled auto-merge June 26, 2022 19:14
@hairyhenderson hairyhenderson disabled auto-merge June 26, 2022 19:20
@hairyhenderson
Copy link
Owner

CI failure's unrelated - merging anyway...

@hairyhenderson hairyhenderson merged commit f051df5 into hairyhenderson:main Jun 26, 2022
@mayurwaghmode
Copy link
Contributor Author

Thanks, @hairyhenderson :)
Can we expect gomplate binaries for ppc64le architecture as part of the releases?

@hairyhenderson
Copy link
Owner

Yes, the next release will contain these. If you need a build in the meantime you can use the latest or alpine tags of the Docker image: https://hub.docker.com/r/hairyhenderson/gomplate/tags

@mayurwaghmode
Copy link
Contributor Author

@hairyhenderson when we are planning for the next release of gomplate?

@mayurwaghmode
Copy link
Contributor Author

@hairyhenderson is there any update regarding the next release of gomplate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants