Add coll.GoSlice and deprecate slice alias #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
deprecate-slice-1461
branch
2 times, most recently
from
2a101ed to
0b6db3b
Compare
hairyhenderson
force-pushed
the
deprecate-slice-1461
branch
2 times, most recently
from
448fdb2 to
33f2537
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
deprecate-slice-1461
branch
from
33f2537 to
5184fa4
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
slicein preparation for removal in a future major version of gomplate (not necessarily v4).Adds
coll.GoSliceto support the same behaviour as thetext/templateslicefunction (that was added after the gomplateslicefunction).See #1461 for details!
Signed-off-by: Dave Henderson [email protected]