Deprecate non-pipelineable strings aliases #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
deprecate-non-pipelineable-strings-aliases-1535
branch
from
8fe2dbe to
0680132
Compare
hairyhenderson
deleted the
deprecate-non-pipelineable-strings-aliases-1535
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion in #1535 between
splitandstrings.Split, which I had intended to deprecate ages ago, but never got around to it...I've deprecated all of the non-pipelineable functions with a notice to use
strings.*instead.This also clarifies (hopefully?) the docs for
strings.Split. I've used the stdlibstrings.Splitdoc as a guide.I'll eventually remove these functions, but not for a while as they're likely to be heavily used.
Signed-off-by: Dave Henderson [email protected]