Bump go4.org/unsafe/assume-no-moving-gc for Go 1.21 support

[stefanb]

Upgrades indirect dependancy go4.org/unsafe/assume-no-moving-gc for compatibility with upcoming Go 1.21: go4org/unsafe-assume-no-moving-gc@e7c30c7

Full upstream diff: go4org/unsafe-assume-no-moving-gc@c31fa08...e7c30c7

It is required via (now archived) module inet.af/netaddr that is used in some Deprecated functions of the public API.

Problem noticed in Homebrew/homebrew-core#134468
Log: https://github.com/Homebrew/homebrew-core/actions/runs/5618619997/job/15224884480?pr=134468#step:3:9232

==> /opt/homebrew/Cellar/gomplate/3.11.5/bin/gomplate --version
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.21rc3 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH="go1.21rc3" set. Notably, if go1.21rc3 adds a moving garbage collector, this program is unsafe to use.

I was able to reproduce the error locally with Go 1.21rc3, but afrer bumping the go4.org/unsafe/assume-no-moving-gc the error went away.

[hairyhenderson]

Thanks @stefanb, I appreciate this!

[mihaitodor]

Thank you for fixing this! I bumped into it by installing gomplate via go install github.com/hairyhenderson/gomplate/v4/cmd/gomplate@latest:

> gomplate --help
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.21 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH="go1.21" set. Notably, if go1.21 adds a moving garbage collector, this program is unsafe to use.

goroutine 1 [running]:
go4.org/unsafe/assume-no-moving-gc.init.0()
	/go/pkg/mod/go4.org/unsafe/[email protected]/untested.go:25 +0x1a0

Would it be possible to have a new tag released so go install can pick up this fix?

[hairyhenderson]

Hmm... if you're installing github.com/hairyhenderson/gomplate/v4 you shouldn't be seeing this (because of this PR)... I would expect this to happen with gomplate v3 though - can you double-check your go install command?

[mihaitodor]

@hairyhenderson I am installing v4, but the issue is that @latest picks up the latest tagged release, namely v4.0.0-pre-0, which doesn't contain the fix. Try running the following:

> go install github.com/hairyhenderson/gomplate/v4/cmd/gomplate@latest
go: downloading github.com/hairyhenderson/gomplate/v4 v4.0.0-pre-0
...
some more output...
...

[hairyhenderson]

🤦‍♂️ I totally forgot v4.0.0-pre-0 existed... sorry about that. I'll tag a -1 soon!

[hairyhenderson]

Done: https://github.com/hairyhenderson/gomplate/releases/tag/v4.0.0-pre-1 - sorry for the confusion!

[mihaitodor]

Thank you very much! ❤️

[erharb]

Hmm... if you're installing github.com/hairyhenderson/gomplate/v4 you shouldn't be seeing this (because of this PR)... I would expect this to happen with gomplate v3 though - can you double-check your go install command?

@hairyhenderson I am currently using gomplate v3 and can confirm we just hit this after updating to go 1.21.1

go: downloading github.com/hairyhenderson/gomplate/v3 v3.11.5
...
panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.21 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH="go1.21" set. Notably, if go1.21 adds a moving garbage collector, this program is unsafe to use.