Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(funcs): add semver functions #1829

Merged
merged 4 commits into from
Nov 24, 2023
Merged

feat(funcs): add semver functions #1829

merged 4 commits into from
Nov 24, 2023

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Aug 29, 2023 •
edited
Loading

  • semver.Version: new a SemVer struct.
  • semver.MatchConstraint: match in arg with semver constraint string.

refer to: https://github.com/Masterminds/sprig/blob/master/semver.go

Based on: #1828

@hairyhenderson
Copy link
Owner

Hi @wuhuizuo, thanks for submitting this, and sorry for the delay. Would it be possible for you to rebase and add some documentation for this?

@wuhuizuo wuhuizuo force-pushed the feature/semver-functions branch from ed0ae20 to c2dc1a3 Compare November 7, 2023 06:15
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Nov 7, 2023 •
edited
Loading

Hi @wuhuizuo, thanks for submitting this, and sorry for the delay. Would it be possible for you to rebase and add some documentation for this?

I updated the documents, but I do not know how to update the markdown with make task:

$ make docs/content/functions/semver.md
make: *** No rule to make target 'docs/content/functions/semver.md'.  Stop.

hairyhenderson
hairyhenderson reviewed Nov 10, 2023
View reviewed changes
funcs/semver.go Outdated Show resolved Hide resolved
@hairyhenderson
Copy link
Owner

I updated the documents, but I do not know how to update the markdown with make task:

Thanks @wuhuizuo - make is failing because you didn't correctly name the file - once you fix that it should run.

@wuhuizuo wuhuizuo force-pushed the feature/semver-functions branch from dd6f8c2 to efbee45 Compare November 13, 2023 12:59
@wuhuizuo
Copy link
Contributor Author

I updated the documents, but I do not know how to update the markdown with make task:

Thanks @wuhuizuo - make is failing because you didn't correctly name the file - once you fix that it should run.

Done, PTAL.

hairyhenderson
hairyhenderson approved these changes Nov 24, 2023
View reviewed changes
Copy link
Owner

@hairyhenderson hairyhenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @wuhuizuo! LGTM

@hairyhenderson hairyhenderson force-pushed the feature/semver-functions branch from efbee45 to 6d66920 Compare November 24, 2023 16:09
@hairyhenderson hairyhenderson enabled auto-merge (squash) November 24, 2023 16:09
@hairyhenderson hairyhenderson added this to the v4.0.0 milestone Nov 24, 2023
@hairyhenderson hairyhenderson merged commit 635e78c into hairyhenderson:main Nov 24, 2023
13 checks passed
@wuhuizuo wuhuizuo deleted the feature/semver-functions branch November 25, 2023 04:39
@wuhuizuo wuhuizuo restored the feature/semver-functions branch November 25, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairyhenderson hairyhenderson hairyhenderson approved these changes

Assignees
No one assigned
Labels
api/minor dependencies new function
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wuhuizuo @hairyhenderson