Fix the wdFS behaviour due to Go 1.21.4's changes to IsAbs #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
wdfs-go1.21.4-fix
branch
4 times, most recently
from
5d553b1 to
8fd2a6b
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
wdfs-go1.21.4-fix
branch
from
8fd2a6b to
41ce8ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of relatively obscure forms of Windows file paths was broken by the security fixes in Go 1.21.4. This PR fixes the logic to be more in-line with how Windows itself categorizes and parses paths.
There's probably an opportunity for more refactoring, but this'll do for now.
This also updates the CI to expose bugs when dealing with non-current volumes on Windows.