feat(strings)!: Update strings.Indent to error on bad input instead of silently doing nothing #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
changed the title
hairyhenderson
force-pushed
the
strings-indent-return-error
branch
from
8693012 to
84e4db4
Compare
hairyhenderson
force-pushed
the
strings-indent-return-error
branch
from
84e4db4 to
5f62936
Compare
… silently doing nothing Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
strings-indent-return-error
branch
from
5f62936 to
9997172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking API change for 4.0 - instead of silently doing nothing when invalid input is provided, the function now errors.