Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api)!: Overhauling config and rendering types #2094

Merged
merged 1 commit into from
Jun 9, 2024
Merged

chore(api)!: Overhauling config and rendering types #2094

merged 1 commit into from
Jun 9, 2024

Conversation

hairyhenderson
Copy link
Owner

@hairyhenderson hairyhenderson commented Jun 3, 2024 •
edited
Loading

Exporting config.Config and changing Renderer-related types as a result. A bunch of renames and shuffles. Everything should remain status quo from a CLI perspective, but this is one of the bigger breaking changes coming to v4.0 for programmatic users.

Fixes #2073

@hairyhenderson hairyhenderson added this to the v4.0.0 milestone Jun 3, 2024
@hairyhenderson hairyhenderson self-assigned this Jun 3, 2024
@hairyhenderson hairyhenderson force-pushed the finalize-renderer-interface-2073 branch from 64ab693 to d261bb9 Compare June 6, 2024 12:22
@hairyhenderson
Copy link
Owner Author

I need to decide whether I want the type in the root package and rename it to something other than Config so as not to conflict with the deprecated type, or go ahead and completely break things and remove RunTemplates and change the deprecated Config type to this new one instead.

I'm going to remove the deprecated RunTemplates and Config - they've been deprecated for 5 minor releases (since 3.7.0), more than 4 years... It's time. But, I'll do that in a separate PR for clarity.

@hairyhenderson hairyhenderson mentioned this pull request Jun 6, 2024
Merged
@hairyhenderson
Copy link
Owner Author

#2095 has the removals, will rebase this after it merges

@hairyhenderson hairyhenderson force-pushed the finalize-renderer-interface-2073 branch 6 times, most recently from ef43adc to 2addfa5 Compare June 8, 2024 17:03
@hairyhenderson hairyhenderson marked this pull request as ready for review June 8, 2024 18:23
@hairyhenderson hairyhenderson force-pushed the finalize-renderer-interface-2073 branch from 2addfa5 to ed67f3e Compare June 9, 2024 23:16
@hairyhenderson hairyhenderson merged commit 47b74a5 into main Jun 9, 2024
15 checks passed
@hairyhenderson hairyhenderson deleted the finalize-renderer-interface-2073 branch June 9, 2024 23:25
@hairyhenderson hairyhenderson mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hairyhenderson hairyhenderson

Labels
api/major
Projects
No open projects
gomplate v4
Status: Done
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

Need to finalize gomplate.Renderer and related types before v4.0.0
1 participant
@hairyhenderson