Relaxing restriction on empty datasources #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
relax-empty-datasource-error
branch
from
e43791b to
6b28889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when #200 was fixed (in #201), the assumption was made that if the data from the datasource was empty (i.e. an empty
[]byte), then this was an error condition and gomplate should effectively stop processing the datasource.It turns out that this was actually a regression, and there are valid scenarios for having empty datasources - maybe a file is empty, and should be able to be parsed (like in #311).
I've re-thought this approach, and instead of being so heavy-handed, I'll allow empty datasources. In the specific Vault case (from #200), I'll simply return an
errorlike I should've in the first place!Signed-off-by: Dave Henderson [email protected]