Return error instead of using log.Fatal #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
return-error-from-funcs
branch
from
3ce3bdb to
da3f87f
Compare
hairyhenderson
force-pushed
the
return-error-from-funcs
branch
10 times, most recently
from
cb56b04 to
9ef8978
Compare
hairyhenderson
changed the title
hairyhenderson
force-pushed
the
return-error-from-funcs
branch
10 times, most recently
from
f5e9f2c to
9c525f3
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
return-error-from-funcs
branch
from
9c525f3 to
cc0dc06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a detour when working on #379, because this has become a pretty major issue and I just want to get it fixed once and for all.
Turns out using
log.Fatalfrom template functions was a terrible idea. Makes it much harder to properly handle/display/track errors, andtext/templatehandles them decently anyway.The basic goal here is to remove all uses of
log.Fatalorlog.Fatalf, and instead change function signatures to return errors instead.Signed-off-by: Dave Henderson [email protected]