Add test.Required function #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
add-required-func
branch
2 times, most recently
from
4f655be to
9e57622
Compare
hairyhenderson
commented
Sep 7, 2018
osterman
reviewed
Sep 7, 2018
osterman
reviewed
Sep 7, 2018
| $ gomplate -d config=config.yaml -i '{{ (ds "config").empty | required "The `config` datasource must have a value defined for `empty`" }}' | ||
| template: <arg>:1:25: executing "<arg>" at <required "The `confi...>: error calling required: The `config` datasource must have a value defined for `empty` | ||
| $ gomplate -d config=config.yaml -i '{{ (ds "config").bogus | required "The `config` datasource must have a value defined for `bogus`" }}' | ||
| template: <arg>:1:7: executing "<arg>" at <"config">: map has no entry for key "bogus" |
There was a problem hiding this comment.
Is there a way we could do something like:
{{ (ds "config") | get "bogus" | required "The `config` datasource must have a value defined for `bogus`"
where get works like getenv and does not error?
There was a problem hiding this comment.
ah, that might work. There is the index built-in, but it doesn't pipeline so well:
$ bin/gomplate -i '{{ $j := (json `{"foo":"bar"}`)}}{{ index $j "baz" | required "nope!" }}'
template: <arg>:1:53: executing "<arg>" at <required "nope!">: error calling required: nope!if only index took arguments the other way around, it'd be a simple case of {{ $j | index "baz" | required "nope!" }}.
I could write an alternate for index that takes arguments in the opposite order for easier pipelining, but it may not be that necessary...
hairyhenderson
force-pushed
the
add-required-func
branch
from
9e57622 to
9174c04
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
add-required-func
branch
from
9174c04 to
15cd750
Compare
hairyhenderson
changed the title
This was referenced Sep 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310
Signed-off-by: Dave Henderson [email protected]