Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subpaths for http datasources #442

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Conversation

hairyhenderson
Copy link
Owner

I thought I could provide a second argument to datasource to build on the URL for HTTP datasources:

gomplate -d d=http://example.com/ -i '{{ datasource "d" "foo/bar/baz" }}'

Which should effectively access http://example.com/foo/bar/baz.

But, it didn't work!

Now, with this PR, it does.

This also splits the http datasource code into a separate file (datasource.go is getting a mite large)

Signed-off-by: Dave Henderson [email protected]

@hairyhenderson hairyhenderson merged commit d97981e into master Dec 4, 2018
@hairyhenderson hairyhenderson deleted the fix-http-subpath-bug branch December 4, 2018 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant