Support subpaths for http datasources #442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I could provide a second argument to
datasource
to build on the URL for HTTP datasources:Which should effectively access
http://example.com/foo/bar/baz
.But, it didn't work!
Now, with this PR, it does.
This also splits the http datasource code into a separate file (
datasource.go
is getting a mite large)Signed-off-by: Dave Henderson [email protected]