Supporting gs (Google Cloud Storage) datasources #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
google-storage-datasource
branch
from
256262c to
428d78c
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
google-storage-datasource
branch
from
428d78c to
2304c68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a pretty logical followup to #625, this adds support for
gs://URLs, pointing to Google Cloud Storage.The testing on this one is pretty weak, partly because you need to be authenticated to read even public data through the API, but mostly because of my complete inexperience with GCS 😉
Signed-off-by: Dave Henderson [email protected]