Adding context.Context support and a logger #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
logger
branch
from
32abdeb to
caeb720
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
logger
branch
from
caeb720 to
5e43a06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting initial work on propagating
context.Contextthroughout gomplate for cleaner cancellation/timeout/etc support, and instead of just usingfmt.Fprintffor logging, switching tozerolog. This has the added benefit that I can now do some verbose logging in "deeper" areas more easily.Introduces a new
gomplate.RunTemplatesWithContextfunction. Not sure I like the name, and I am likely to change the signature in #692.Signed-off-by: Dave Henderson [email protected]