Normalize file modes for Windows #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
fix-windows-file-modes-948
branch
from
567dd69 to
5e72366
Compare
hairyhenderson
force-pushed
the
fix-windows-file-modes-948
branch
4 times, most recently
from
665ee47 to
b888f63
Compare
hairyhenderson
force-pushed
the
fix-windows-file-modes-948
branch
4 times, most recently
from
5c4749d to
83923f5
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
fix-windows-file-modes-948
branch
from
83923f5 to
91f0cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #948
On Windows, the UNIX chmod values don't work as expected. Basically there are only 3 acceptable modes - read-write (
0666), read-only (0444), and no access (0000). To make matters worse, if you create a file with mode0644, it'll be interpreted as0444and the file will not be writeable.This adds an internal utility to convert the file mode from the intended mode to something that will actually work cross-platform.
Signed-off-by: Dave Henderson [email protected]