Add: enable .well-known/acme-challenge when https #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've added a small change for the NGINX template:
Enable the NGINX route .well-known/acme-challenge only,
when using LetsEncrypt and activating HTTPS-protocol.
Why?
When using an external reverse proxy which is terminating TLS and itself is using
LetsEncrypt with a http based challenge it gets in conflict with the NGINX running in the container.
It looks like the containers NGINX will get the traffic before the proxy in front of it.
Additionally when running the container with http only, this would unnecessary
increase the NGINX configuration in a confusing way.