Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation error in README #32

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Fix documentation error in README #32

merged 1 commit into from
Apr 2, 2022

Conversation

bfontaine
Copy link
Contributor

HTMLMIN.init_app(app) doesn’t work because it’s an instance method, not a class one.

`HTMLMIN.init_app(app)` doesn’t work because it’s an instance method, not a class one.
@codecov-commenter
Copy link

Codecov Report

Merging #32 (cec57e4) into master (8ea133b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files           1        1           
  Lines          79       79           
=======================================
  Hits           76       76           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ea133b...cec57e4. Read the comment docs.

@hamidfzm
Copy link
Owner

Thanks for MR. I think changing it to htmlmin.init_app(app) would be better.

@hamidfzm hamidfzm merged commit e4790ba into hamidfzm:master Apr 2, 2022
@bfontaine bfontaine deleted the patch-1 branch April 3, 2022 11:34
@bfontaine
Copy link
Contributor Author

Sorry I didn’t get any notification for your comment so I only see it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants