Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler-api example #1303

Merged
merged 2 commits into from
Jan 29, 2017
Merged

Fix compiler-api example #1303

merged 2 commits into from
Jan 29, 2017

Conversation

nknapp
Copy link
Collaborator

@nknapp nknapp commented Jan 29, 2017 •
edited
Loading

While trying to answer #1302, I noticed that the compiler-api example did not work in (because nameLookup is actually at the prototype).
This example has a jsfiddle that proves it is working.

Before creating a pull-request, please check https://github.com/wycats/handlebars.js/blob/master/CONTRIBUTING.md first.

Generally we like to see pull requests that

  • Maintain the existing code style
  • Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
  • Have good commit messages
  • Have tests (no code has been changed)
  • Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)

nknapp added 2 commits January 29, 2017 07:00
@nknapp
Fix compiler-api example
8ce1b6e 
While trying to answer #1302, I noticed that the compiler-api example did not work in (because `nameLookup` is actually at the prototype).
This example has a jsfiddle that proves it is working.
@nknapp
Remove jsfiddle-specifics from example
728a26e 
Updates the example such that no jsfiddle elements are involved.
@nknapp nknapp changed the title WIP: Fix compiler-api example Fix compiler-api example Jan 29, 2017
@nknapp nknapp merged commit c997020 into master Jan 29, 2017
@nknapp nknapp deleted the nknapp-compiler-api-example branch February 14, 2017 21:00
nknapp added a commit that referenced this pull request Mar 9, 2017
@nknapp
Fix compiler-api example (#1303)
1130b5d 
Closes #1302 

While trying to answer #1302, I noticed that the compiler-api example did not work in (because `nameLookup` is actually at the prototype). This example has a jsfiddle that proves it is working.
It does not provide an solve the exact problem of the reporter, but it answers the question.
@renovate-bot renovate-bot mentioned this pull request Apr 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nknapp