Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added -w, --watch option to the handlebars CLI #1330

Closed
wants to merge 2 commits into from
Closed

Added -w, --watch option to the handlebars CLI #1330

wants to merge 2 commits into from

Conversation

m-ahmadi
Copy link

@m-ahmadi m-ahmadi commented Apr 9, 2017

Watch option for the handlebars CLI.
It watches for changes on the input file(s) / dir(s), and performs reprecompilation on changes to them.
I used the 'chokidar' package for watching files and folders, and the 'color' package for outputing nice looking messages to the console.

…hich watches for changes on the input file(s)/dir(s), and performs reprecompilation on changes to them, I used the 'chokidar' package for watching files and dirs, and the 'color' package for outputing nice looking messages to the console.
@m-ahmadi
Copy link
Author

m-ahmadi commented Apr 9, 2017

If you don't want the ES6 stuff, tell me to replace them.

	Replaced optimist with yargs. My bad!.
@m-ahmadi m-ahmadi closed this Apr 9, 2017
@nknapp
Copy link
Collaborator

nknapp commented Apr 9, 2017

I personally feel a bit controversial about this request. "chokidar" adds another 2MB to the total size of Handlebars. I have a few projects that use Handlebars and I am constantly trying to reduce the size of those projects.
I think that such a development tool should be in a separate project.

But, this is my opinion only. There may be different ones.

@stevenvachon
Copy link

This should probably be handled with npm-watch, since it can restart the process, which is particularly useful if the current process is not yet complete.

@m-ahmadi
Copy link
Author

m-ahmadi commented Apr 9, 2017

I made another pr and changed it from two commits into one, and made the commit msg nicer, can you guys please copy-paste your comments there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants