Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 665: pin es6-module-transpiler at 0.3.3 with npm-shrinkwrap #666

Closed

Conversation

soxofaan
Copy link

Issue #665: handlebars build is broken with es6-module-transpiler v0.3.4
(also see esnext/es6-module-transpiler#81 and esnext/es6-module-transpiler#82)

This PR adds npm-shrinkwrap.json, to pin dependecies to desired versions (such as 0.3.3 of es6-module-transpiler),

@eventualbuddha
Copy link

v0.3.5 was just released which should resolve the issue.

@kpdecker
Copy link
Collaborator

kpdecker commented Dec 1, 2013

Thanks for the PR but I've gone a little bit of a different direction with the fix here.

I've reworked the module packager project so that it supports all of the transpile needs and pined the version to 0.3.3 in there as 0.3.5 looks like it does not have the fix from esnext/es6-module-transpiler#82 compiled in.

The handlebars side of these changes were implemented in 57b4ef0 and you'll need to update your npm dependencies for everything to work locally.

@kpdecker kpdecker closed this Dec 1, 2013
@soxofaan
Copy link
Author

soxofaan commented Dec 1, 2013

no problem, as long as building handlebars does not fail with obscure error messages :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants