Import hs-client into the project.

[nodech]

hsd and hs-client are tightly coupled. When major or minor changes occur hs-client needs to reflect them right away. The versioning scheme should be exactly the same as well, which has not been the case up til now (we used patches there). If versions don't match, users will have trouble figuring out which hs-client version to use with which hsd.

The most troublesome part is the major breaking changes, if something breaks hs-client it becomes troublesome to manage hs-client. Having client alongside with hsd make this really simple.

Standalone version of hs-client is also necessary, for those who want minimal functionality w/o all heavy dependencies in their projects. So this PR introduces script in scripts/gen-hsclient.js which can aid with pushing and publishing of the hs-client both to github and npm.

To sum it up:

• Pros
  • Easier to work with, especially for breaking API changes.
  • Easier and better management version of the hs-client.
• Cons
  • Contributors need to be aware of the hs-client files and not introduce dependencies that make standalone 'hs-client' heavy (see scripts/gen-hsclient.js).
  • Extra step in the release process (which should have already been happening if we want better versioning of hs-client)

You can review usage update here: https://github.com/nodech/hsd/blob/6bd7cc0a825facf9dec7894888950939d7b427df/docs/release-files.md#hs-client

[coveralls]

Coverage: 68.39% (-0.05%) from 68.438% when pulling 2dc2c48 on nodech:import-hs-client into 6314c1a on handshake-org:master.

[rithvikvibhu]

I think this makes a lot of sense and each api change won't need to track a sibling PR on another repo. I've tried this branch and the generated hs-client and other than the slightly awkward process to dev hs-client (discussed in https://t.me/hns_tech/74474) everything looks good to me.

Q: What do you think about the exposed bins of both hsd and hs-client now? Currently, hsd has hs*-cli and hs-client has hs*-cli, hs*-rpc. I get that hs-client will still be a separate package, but maybe hsd can add hs*-rpc as well? So users won't need to install hs-client for the rpc shortcuts. I bring this up because hsd and hs-client both can't be installed globally without --force overwriting the two conflicting bin files.

Non-blocking suggestions:

• HS_CLIENT_DIR but as an arg to the script
• an option to the script arg to only generate content, without any git work

[rithvikvibhu]

This is awesome, can finally maintain both packages together. The new script args work great. Left some non-blocking comments.