Improvement: Discrite Held Time #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalMWolfs
requested changes
Dec 22, 2024
There was a problem hiding this comment.
All the code is fine except that fixRemovedConfigElement is only called for config version 29 which means that this wont actually do the config fix that you are wanting it to for 99% of people.
You'd have to make a new function for a new config fix version. You may as well change the enum name now as well in this new function
CalMWolfs
approved these changes
Dec 22, 2024
|
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
github-actions
bot
added
the
Merge Conflicts
github-actions
bot
removed
the
Merge Conflicts
|
Conflicts have been resolved! 🎉 |
jani270
added
the
Soon
github-actions
bot
removed
the
Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added Discrite support for time held in lore and stack size. Also refactored related code a bit, and made the stack size a single option for all Time Pocket items, just like the lore option is, since I do not see a reason why someone would want it for some but not all of them.
(I kept the enum nameBOTTLE_OF_JYRREbecause I didn't want to make a mess with a multi-level migration considering it also has a legacy ID.)Changelog Improvements