Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature + Fix: Xp In Inventory #3253

Merged
merged 7 commits into from
Jan 24, 2025

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Jan 19, 2025

What

Adds the currents player xp in the lore of xp apply lore(..?)
Works best with the newely added skyblock level in xp bar feature.

Images

2025-01-19_18 47 41
2025-01-19_18 40 14

Changelog New Features

  • Added XP in Inventory. - j10a1n15
    • Showing current XP in item lore of XP-dependent menus (e.g., Experimentation Table, Anvil, Hex).
    • This ensures XP visibility even when replaced by the SkyBlock XP bar.

Changelog Fixes

  • Fixed SkyBlock XP Bar overriding other mods. - j10a1n15

Signed-off-by: J10a1n15 <[email protected]>
@hannibal002
Copy link
Owner

please indicate that this is due to the sb level xp bar

@j10a1n15
Copy link
Contributor Author

Its not though, its its own feature. It just works best with the bar, which is alr stated in the bar config.

@hannibal002 hannibal002 added this to the Version 2.0.0 milestone Jan 19, 2025
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Jan 19, 2025
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 19, 2025
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jan 19, 2025
Copy link

Conflicts have been resolved! 🎉

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without skyblcok xp bar
image

with skyblcok xp bar
image
image

@j10a1n15 j10a1n15 requested a review from hannibal002 January 24, 2025 16:09
Copy link

I have detected some issues with your pull request:

Title issues:
PR title must include category 'Fix' if there are any fixes in the PR

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Jan 24, 2025
@j10a1n15 j10a1n15 changed the title Feature: Xp In Inventory Feature + Fix: Xp In Inventory Jan 24, 2025
@github-actions github-actions bot added Bug Fix Bug fixes and removed Wrong Title/Changelog There is an error in the title or changelog labels Jan 24, 2025
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@hannibal002 hannibal002 enabled auto-merge (squash) January 24, 2025 17:38
@hannibal002 hannibal002 merged commit 6a31970 into hannibal002:beta Jan 24, 2025
6 checks passed
@github-actions github-actions bot removed Soon This Pull Request will be merged within the next couple of betas Bug Fix Bug fixes labels Jan 24, 2025
@j10a1n15 j10a1n15 deleted the feature/xp-in-inventory branch January 25, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants