Skip to content

Commit

Permalink
chore: only upload DSYM on production
Browse files Browse the repository at this point in the history
  • Loading branch information
hansemannn committed Mar 9, 2019
1 parent 4a481c9 commit 435a56e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions ios/hooks/ti.runscriptphase.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ exports.init = function (logger, config, cli, appc) {
const builder = this;
const xcodeProject = data.args[0];

if (builder.deployType !== 'production') {
console.log('Not in production, skipping Crashlytics DSYM upload …');
return;
}

var xobjs = xcodeProject.hash.project.objects;

if (typeof builder.generateXcodeUuid !== 'function') {
Expand Down Expand Up @@ -53,7 +58,6 @@ function addScriptBuildPhase(builder, xobjs, scriptPath, appc) {
}

function createPBXRunShellScriptBuildPhase(xobjs, script_uuid, shell_path, shell_script, input_paths) {
console.log('Creating run shell-script build phase');
xobjs.PBXShellScriptBuildPhase = xobjs.PBXShellScriptBuildPhase || {};

xobjs.PBXShellScriptBuildPhase[script_uuid] = {
Expand All @@ -69,11 +73,10 @@ function createPBXRunShellScriptBuildPhase(xobjs, script_uuid, shell_path, shell
}

function createPBXRunScriptNativeTarget(xobjs, script_uuid) {
console.log('Creating run shell-script native target');
for (const key in xobjs.PBXNativeTarget) {
xobjs.PBXNativeTarget[key].buildPhases.push({
value: script_uuid + '',
comment: 'Titanium Crashlytics'
comment: '[Ti] Crashlytics'
});
return;
}
Expand Down
2 changes: 1 addition & 1 deletion ios/manifest
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# this is your module manifest and used by Titanium
# during compilation, packaging, distribution, etc.
#
version: 1.2.0
version: 1.2.1
apiversion: 2
architectures: armv7 arm64 i386 x86_64
description: titanium-crashlytics
Expand Down

0 comments on commit 435a56e

Please sign in to comment.