Merge pull request #4 from petenathan42/petenathan42-incrementMetric

use incrementMetric instead of incrementCounter
hansemannn · Oct 16, 2021 · 30b70f1 · 30b70f1
2 parents bc0db91 + 89188db
commit 30b70f1
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/android/build.gradle b/android/build.gradle
@@ -0,0 +1,3 @@
+dependencies {
+	implementation 'com.google.firebase:firebase-perf:20.0.3'
+}
diff --git a/android/lib/firebase-perf-11.0.4.aar b/android/lib/firebase-perf-11.0.4.aar
diff --git a/android/manifest b/android/manifest
@@ -2,9 +2,9 @@
 # this is your module manifest and used by Titanium
 # during compilation, packaging, distribution, etc.
 #
-version: 1.0.0
+version: 2.0.0
 apiversion: 4
-architectures: arm64-v8a armeabi-v7a x86
+architectures: arm64-v8a armeabi-v7a x86 x86_64
 description: titanium-firebase-performance
 author: Hans Knoechel
 license: Apache 2
@@ -15,4 +15,4 @@ name: titanium-firebase-performance
 moduleid: firebase.performance
 guid: 4e3c4e2d-afea-42e5-86f6-d2bdc0767130
 platform: android
-minsdk: 7.0.0
+minsdk: 9.0.0
diff --git a/android/src/firebase/performance/TitaniumFirebasePerformanceModule.java b/android/src/firebase/performance/TitaniumFirebasePerformanceModule.java
@@ -70,12 +70,7 @@ public void incrementCounter(String identifier, String counterName, Object incre
     }
 
     Trace trace = this.traces.get(identifier);
-
-    if (incrementedBy != null) {
-      trace.incrementCounter(counterName, (long) TiConvert.toInt(incrementedBy));
-      return;
-    }
 
-    trace.incrementCounter(counterName);
+    trace.incrementMetric(counterName, (long) TiConvert.toInt(incrementedBy));
   }
 }