Fix tests for node v17 #4314
Merged
Fix tests for node v17 #4314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
commented
Nov 9, 2021
cjihrig
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we will not officially support node v17 since it is not an LTS version of node, in practice we would like to test hapi against it and ensure everything will be in good shape when node v18 eventually arrives.
The hapi test suite was affected by the change in DNS ordering in nodejs/node#39987, since default hapi servers would need to be connected to using
::1over ipv6 rather than127.0.0.1over ipv4. In the next major version of hapi we should consider how we might make ouraddressdefault (currently0.0.0.0) more ipv6-aware.We are also currently affected by a bug nodejs/node#40528 slated to be resolved in node v17.1.0. The one
skip()in the test suite relates to this: we skip the test for now to avoid a hang caused by the bug.Note that the test suite is going to be all red right now due to nodejs/node#40528. Once that is resolved I will re-run the tests and turn this into a non-draft PR if everything is passing.