Adds SecurityDetails.subjectAlternativeNames (#2820)

* Adds SecurityDetails.subjectAlternativeNames which is part of the Puppeteer API but not yet in PuppeterSharp * Patch version bump --------- Co-authored-by: Jeff Peirson <[email protected]>
hardkoded · Nov 7, 2024 · c908c5c · c908c5c
1 parent 874c78d
commit c908c5c
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/lib/PuppeteerSharp/PuppeteerSharp.csproj b/lib/PuppeteerSharp/PuppeteerSharp.csproj
@@ -12,10 +12,10 @@
     <Description>Headless Browser .NET API</Description>
     <PackageId>PuppeteerSharp</PackageId>
     <PackageReleaseNotes></PackageReleaseNotes>
-    <PackageVersion>20.0.4</PackageVersion>
-    <ReleaseVersion>20.0.4</ReleaseVersion>
-    <AssemblyVersion>20.0.4</AssemblyVersion>
-    <FileVersion>20.0.4</FileVersion>
+    <PackageVersion>20.0.5</PackageVersion>
+    <ReleaseVersion>20.0.5</ReleaseVersion>
+    <AssemblyVersion>20.0.5</AssemblyVersion>
+    <FileVersion>20.0.5</FileVersion>
     <SynchReleaseVersion>false</SynchReleaseVersion>
     <StyleCopTreatErrorsAsWarnings>false</StyleCopTreatErrorsAsWarnings>
     <DebugType>embedded</DebugType>

diff --git a/lib/PuppeteerSharp/SecurityDetails.cs b/lib/PuppeteerSharp/SecurityDetails.cs
@@ -22,12 +22,27 @@ public SecurityDetails()
         /// <param name="validTo">Valid to.</param>
         /// <param name="protocol">Protocol.</param>
         public SecurityDetails(string subjectName, string issuer, long validFrom, long validTo, string protocol)
+         : this(subjectName, issuer, validFrom, validTo, protocol, [])
+        {
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="SecurityDetails"/> class.
+        /// </summary>
+        /// <param name="subjectName">Subject name.</param>
+        /// <param name="issuer">Issuer.</param>
+        /// <param name="validFrom">Valid from.</param>
+        /// <param name="validTo">Valid to.</param>
+        /// <param name="protocol">Protocol.</param>
+        /// <param name="subjectAlternativeNames">Subject alternative names.</param>
+        public SecurityDetails(string subjectName, string issuer, long validFrom, long validTo, string protocol, string[] subjectAlternativeNames)
         {
             SubjectName = subjectName;
             Issuer = issuer;
             ValidFrom = validFrom;
             ValidTo = validTo;
             Protocol = protocol;
+            SubjectAlternativeNames = subjectAlternativeNames;
         }
 
         /// <summary>
@@ -59,5 +74,11 @@ public SecurityDetails(string subjectName, string issuer, long validFrom, long v
         /// </summary>
         /// <value>The protocol.</value>
         public string Protocol { get; set; }
+
+        /// <summary>
+        /// Gets the list of subject alternative names (SANs) of the certificate.
+        /// </summary>
+        /// <value>The list of subject alternative names (SANs) of the certificate.</value>
+        public string[] SubjectAlternativeNames { get; set; }
     }
 }