Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch integer encoding in SSZ to little endian #19

Closed
zilm13 opened this issue Jan 15, 2019 · 2 comments
Closed

Switch integer encoding in SSZ to little endian #19

zilm13 opened this issue Jan 15, 2019 · 2 comments
Labels
SSZ

Comments

@zilm13
Copy link
Member

zilm13 commented Jan 15, 2019

If pull request is merged
ethereum/consensus-specs#139
we should change our implementation to handle numbers as little endians
@mkalinin mkalinin added the SSZ label Jan 15, 2019
@zilm13
Copy link
Member Author

zilm13 commented Jan 17, 2019

Pull request is merged, we should switch encoding of integers from big endian to little endian

@zilm13
Copy link
Member Author

zilm13 commented Jan 22, 2019

Use latest cava-ssz for this as they have fixed Java8 compatibility.
Also remove usages of readUnsignedBigInteger and readUnsignedBigIntegerList due to cava-ssz bug as it was fixed.

@zilm13 zilm13 mentioned this issue Feb 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SSZ
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkalinin @zilm13