Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ssz updates #95

Merged
merged 5 commits into from
Mar 6, 2019
Merged

Ssz updates #95

merged 5 commits into from
Mar 6, 2019

Conversation

zilm13
Copy link
Member

@zilm13 zilm13 commented Feb 28, 2019

Fixes all ssz debts:

  1. resolves Switch integer encoding in SSZ to little endian #19
  2. renames hash_tree_root to hash_tree_root_internal
    ethereum/eth2.0-specs#543
  3. uses merkle_hash instead of hash for containers
    ethereum/eth2.0-specs#595
    it had error in the spec but spec is going to be rewritten with fix of this error, so it's not up to v0.4 version spec, because it has my own fix and it's not up to rewritten spec, because it's not final. Anyway 0.4 is not correct in ssz
  4. Tree hash bytes[] as List(Bytes1) and skip length prefix for fixed byte arrays
    ethereum/eth2.0-specs#596

@zilm13 zilm13 changed the title Ssz updates [WIP] Ssz updates Feb 28, 2019
@zilm13
Copy link
Member Author

zilm13 commented Feb 28, 2019

Please, don't merge
Will try to update according to rewritten hash_tree spec, if it changes anything or confirm that this implementation matches it.

@zilm13
Copy link
Member Author

zilm13 commented Feb 28, 2019

  1. implemented spec rewrite Rewrite SSZ spec ethereum/consensus-specs#696
    still WIP, need to clarify several things

@zilm13 zilm13 changed the title [WIP] Ssz updates Ssz updates Mar 5, 2019
@zilm13 zilm13 requested a review from mkalinin March 5, 2019 17:48
mkalinin
mkalinin approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkalinin mkalinin merged commit b000690 into master Mar 6, 2019
@zilm13 zilm13 mentioned this pull request Mar 6, 2019
Closed
@zilm13 zilm13 deleted the fix/ssz-updates branch March 6, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkalinin mkalinin mkalinin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zilm13 @mkalinin