Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSZ: Incremental tree hash for List #57

Closed
zilm13 opened this issue Feb 1, 2019 · 6 comments
Closed

SSZ: Incremental tree hash for List #57

zilm13 opened this issue Feb 1, 2019 · 6 comments
Labels
SSZ

Comments

@zilm13
Copy link
Member

zilm13 commented Feb 1, 2019

In future we could have giant lists, say, with 1 million of validators, so hashing it on demand may take few seconds which is unacceptable. Research team suggests to build hash for list incrementally and made a proto in Python https://github.com/ethereum/research/tree/master/ssz_hashable_list
We need to do the same thing in Java and use it for such kind of items.
@zilm13 zilm13 added the SSZ label Feb 1, 2019
@zilm13
Copy link
Member Author

zilm13 commented Feb 4, 2019 •
edited
Loading

but it looks like this fix goes after 1st release

UPDATED: should be fixed with 3b0793a

@zilm13
Copy link
Member Author

zilm13 commented Feb 4, 2019 •
edited
Loading

and rename hash_tree_root to hash_tree_root_internal
ethereum/consensus-specs#543
UPDATED: resolved with #95

@zilm13
Copy link
Member Author

zilm13 commented Feb 13, 2019 •
edited
Loading

and ethereum/consensus-specs#602

UPDATED: should be fixed with 3b0793a

@zilm13
Copy link
Member Author

zilm13 commented Feb 24, 2019 •
edited
Loading

use merkle_hash instead of hash for containers
ethereum/consensus-specs#595

UPDATED: resolved with #95

@zilm13
Copy link
Member Author

zilm13 commented Feb 24, 2019 •
edited
Loading

Tree hash bytes[] as List(Bytes1)
ethereum/consensus-specs#596

UPDATED: resolved with #95

@zilm13
Copy link
Member Author

zilm13 commented May 13, 2019

resolved by #115 #122

@zilm13 zilm13 closed this as completed May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SSZ
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zilm13