Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Some missing filters vs Shopify's implementation #132

Closed
pmalouin opened this issue Jun 11, 2019 · 2 comments
Closed

Feature Request: Some missing filters vs Shopify's implementation #132

pmalouin opened this issue Jun 11, 2019 · 2 comments
Assignees
@harttle
Labels
feature requested

Comments

@pmalouin
Copy link
Contributor

Shopify's liquid implementation currently includes some filters that are not supported by this library.

For example, compact is used to filter empty elements from an array.
Documentation: https://shopify.github.io/liquid/filters/compact/
Original PR: Shopify/liquid#600

Other missing filters that are documented:
at_least: https://shopify.github.io/liquid/filters/at_least/
at_most: https://shopify.github.io/liquid/filters/at_most/
sort_natural: https://shopify.github.io/liquid/filters/sort_natural/

In the spirit of feature parity, would you consider adding these filters to this library or are there reasons they are excluded?

Thanks!
@harttle
Copy link
Owner

harttle commented Jun 11, 2019 •
edited
Loading

All standard filters are expected to be included in this repo. It'll be appreciated to provide a PR, or later when I have time to get on it.

@harttle harttle self-assigned this Jul 5, 2019
harttle added a commit that referenced this issue Jul 5, 2019
@harttle
feat: at_least, at_most, sort_naturual for #132
e6f5f1c
harttle pushed a commit that referenced this issue Jul 6, 2019
@semantic-release-bot
chore(release): 8.4.0 [skip ci]
5adebaa 
# [8.4.0](v8.3.0...v8.4.0) (2019-07-06)

### Features

* at_least, at_most, sort_naturual for [#132](#132) ([e6f5f1c](e6f5f1c))
@harttle harttle closed this as completed Jul 6, 2019
@pmalouin
Copy link
Contributor Author

pmalouin commented Jul 8, 2019

@harttle Thanks so much for tackling these improvements in e6f5f1c ❤️ !

At this point, only the compact filter is still missing: https://shopify.github.io/liquid/filters/compact/

@snyk-bot snyk-bot mentioned this issue Apr 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harttle harttle

Labels
feature requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmalouin @harttle