Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression v9] Comparison operator with no space after first operand is always false #186

Closed
slavivanov opened this issue Feb 6, 2020 · 2 comments
Labels

Comments

@slavivanov
Copy link
Contributor

slavivanov commented Feb 6, 2020

Hi, and first of all thank you for the awesome Liquid implementation.

We recently upgraded a to latest version 9 and discovered the following regression (the following worked up to 8.5.3):
{% if true==true %}success{%else%}fail{% endif %} outputs "fail".
The same thing happens when using a variable:
{% assign var = 1 %} {% if var==1 %}success{%else%}fail{% endif %} outputs "fail".

If there is a space after the first operand, the comparison works:
{% if true ==true %}success{%else%}fail{% endif %} outputs "success".

Same repro case in Runkit: https://runkit.com/slavivanov/5e3c7cd5be5ed70017e8a265

@harttle harttle added the bug label Feb 7, 2020
harttle pushed a commit that referenced this issue Feb 7, 2020
# [9.7.0](v9.6.2...v9.7.0) (2020-02-07)

### Bug Fixes

* expression and string literal parser, [#186](#186) ([fc0cf6f](fc0cf6f))

### Features

* globals shared between tags, see [#185](#185) ([870e7ec](870e7ec))
@harttle
Copy link
Owner

harttle commented Feb 7, 2020

Try [email protected], it should be fixed.

@harttle harttle closed this as completed Feb 7, 2020
@slavivanov
Copy link
Contributor Author

You are too cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants