missed filter not throwing parse error

[palsorbo]

Hii !

Facing an issue can you help me out.

Running {{ data_due_date | default:'Nov 30' date:'%b %d' }} template on liqp throws parse error.

Exception in thread "main" liqp.exceptions.LiquidException: parser error "extraneous input 'date' expecting {OutEnd, '|'}" on line 1, index 36.

But running the same template with liquidjs engine throws no parse error. Is this a bug?

Thank you.

[harttle]

There is a strictFilters option available, here's a demo: https://jsfiddle.net/kxetzqh5/

[palsorbo]

Hey, thank you for the quick response.

Here added a demo: https://jsfiddle.net/sarbajit/hrxmsedp/7/

In the second h3 tag the parsing fails in Liqp.

[harttle]

Thank you for clarification. If I understand correctly, it's about how to handle invalid filter syntax. The content of the second h3 in the jsfiddle above is:

{{ age | default: 'now'  date: '%d'}}    // missing `|` before `date`

• shopify/liquid throws wrong number of arguments
• liqp throws parser error "extraneous input 'date'
• liquidjs just skips the intended date filter

It's indeed invalid syntax, so I'm considering throw an ParseError maybe something like invalid filter argument or unexpected ":" and it should be thrown regardless the value of strictFilters.

[github-actions]

🎉 This issue has been resolved in version 9.36.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀