Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jekyll-like include parameters: {% include file key=val %} to expose key=val inside "include" hash - that is, access via {{ include.key }} to access "val" #441

Closed
Nowaker opened this issue Jan 18, 2022 · 1 comment

Comments

@Nowaker
Copy link
Contributor

Nowaker commented Jan 18, 2022

Liquid:

  • parent: {% include file key=val %}
  • child: {{ key }}

Jekyll

  • parent: {% include file key=val %}
  • child: {{ include.key }}

Proposal

  1. Offer support for Jekyll approach OOTB and expose val both in {{ key }} and {{ include.key }}
  2. Offer an optional Jekyll mode, and when enabled, expose include parameters variable in {{ include.key }} only

CC @harttle

As per: https://jekyllrb.com/docs/includes/#passing-parameters-to-includes

github-actions bot pushed a commit that referenced this issue Jan 19, 2022
# [9.33.0](v9.32.1...v9.33.0) (2022-01-19)

### Features

* support `offset:continue`, see [#439](#439) ([8c27a84](8c27a84))
* support Jekyll-like include syntax, see [#441](#441) ([388d0fb](388d0fb))
@Nowaker
Copy link
Contributor Author

Nowaker commented Jan 19, 2022

Thank you @harttle. I can confirm it works!

@harttle harttle closed this as completed Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants