You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
String filters such as split, remove, and replace break when the filter argument has one of the following special characters in it:
[ ( ) |
Note that paired brackets [] and parentheses () do not break the regex filter. Other special characters \ ^ $ . | ? * + { } do not seem to throw an error, but since they are unescaped they could potentially cause unexpected results.
LiquidJS should have some sort of escaping function to prevent this from happening.
It's a bug related to the tokenizer, which treats | as filter separator literally. That tokenizer should be rewritten into a state of the art fashion as well.
String filters such as split, remove, and replace break when the filter argument has one of the following special characters in it:
[ ( ) |
Note that paired brackets
[]
and parentheses()
do not break the regex filter. Other special characters\ ^ $ . | ? * + { }
do not seem to throw an error, but since they are unescaped they could potentially cause unexpected results.LiquidJS should have some sort of escaping function to prevent this from happening.
Note that this testing was down with the browser based version of liquidjs (https://unpkg.com/[email protected]/dist/liquid.min.js)
The text was updated successfully, but these errors were encountered: