Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow drops in property access #769

Merged
merged 1 commit into from
Nov 17, 2024
Merged

feat: allow drops in property access #769

merged 1 commit into from
Nov 17, 2024

Conversation

santialbo
Copy link
Contributor

I noticed I wasn't able to use a Drop as a property access. This PR allows using Drops as key.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11854988621

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.971%
Totals Coverage Status
Change from base Build 11800996948: 0.0%
Covered Lines: 2542
Relevant Lines: 2542
💛 - Coveralls

harttle
harttle approved these changes Nov 15, 2024
View reviewed changes
src/context/context.ts Show resolved Hide resolved
src/render/expression.spec.ts Show resolved Hide resolved
@harttle harttle added the Drop label Nov 15, 2024
@harttle harttle changed the title fix: allow drops in property access feat: allow drops in property access Nov 15, 2024
@harttle harttle merged commit 11f013b into harttle:master Nov 17, 2024
15 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 17, 2024
@semantic-release-bot
chore(release): 10.19.0 [skip ci]
062b351 
# [10.19.0](v10.18.0...v10.19.0) (2024-11-17)

### Features

* allow drops in property access ([#769](#769)) ([11f013b](11f013b))
* support Jekyll style `where`, [#768](#768) ([9107eb1](9107eb1))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 10.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@harttle
Copy link
Owner

harttle commented Nov 17, 2024

@all-contributors please add @santialbo as contributor for code.

@allcontributors allcontributors bot mentioned this pull request Nov 17, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@harttle

I've put up a pull request to add @santialbo! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harttle harttle harttle approved these changes

Assignees
No one assigned
Labels
Drop released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santialbo @coveralls @harttle