feat: Add adminKey flag to node setup command

[Ivo-Yankov]

Description

Related Issues

• Closes add flags to supply keys to use for node admin keys when creating genesis-network.json file #1042

[github-actions]

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   4s ⏱️ ±0s
233 tests ±0  233 ✅ ±0  0 💤 ±0  0 ❌ ±0 
238 runs  ±0  238 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1afa97f. ± Comparison against base commit 89c557a.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   13s ⏱️ -1s
233 tests ±0  233 ✅ ±0  0 💤 ±0  0 ❌ ±0 
238 runs  ±0  238 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1afa97f. ± Comparison against base commit 89c557a.

♻️ This comment has been updated with latest results.

[github-actions]

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 25m 37s ⏱️ - 2m 8s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
269 runs  ±0  269 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1afa97f. ± Comparison against base commit 89c557a.

[github-actions]

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 25m 37s ⏱️ - 2m 8s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
269 runs  ±0  269 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1afa97f. ± Comparison against base commit 89c557a.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.09% (target: -1.00%)	✅ 16.67%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (89c557a)	21412	17873	83.47%
Head commit (1afa97f)	21467 (+55)	17899 (+26)	83.38% (-0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1193)	30	5	16.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[codecov]

Codecov Report

Attention: Patch coverage is 16.66667% with 25 lines in your changes missing coverage. Please review.

Project coverage is 82.56%. Comparing base (89c557a) to head (1afa97f).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...network_models/genesis_network_data_constructor.ts	8.00%	23 Missing ⚠️
src/commands/node/tasks.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1193      +/-   ##
==========================================
- Coverage   82.66%   82.56%   -0.11%     
==========================================
  Files          77       77              
  Lines       21440    21467      +27     
  Branches     1914     1361     -553     
==========================================
  Hits        17724    17724              
- Misses       3593     3689      +96     
+ Partials      123       54      -69     

Files with missing lines	Coverage Δ
src/commands/flags.ts	75.47% <100.00%> (+0.01%)	⬆️
src/commands/node/configs.ts	92.51% <100.00%> (+0.01%)	⬆️
src/commands/node/flags.ts	100.00% <100.00%> (ø)
src/commands/node/tasks.ts	92.33% <0.00%> (-0.11%)	⬇️
...network_models/genesis_network_data_constructor.ts	23.74% <8.00%> (-2.99%)	⬇️

... and 35 files with indirect coverage changes

[jeromy-cannon]

@Ivo-Yankov ,

A few questions/thoughts:

1. As someone using Solo, how do I provide a different key for each node? When looking at the code I see that you allow a comma separated list of keys. However, when looking at the flags.ts code, I only see the description: Admin key. I think we need to provide a better description and provide a usage example.
2. Since we don't sign anything, I think it would be more friendly to just supply the public key. It will be smaller, easier to supply on the command line, and will be safer, since the private key isn't really needed here.
3. rename the flag from --admin-key to --admin-public-keys