Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ingress configuration for mirror explorer #1196

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • Add flags for enable explorer ingress and static ip of mirror service
  • Fix mirror pvc not being deleted due to incorrect labels

Related Issues

Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
…mirror-proxy

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/mirror_node.ts
Signed-off-by: Jeffrey Tang <[email protected]>
…explorer

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/mirror_node.ts
Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/mirror_node.ts
Signed-off-by: Jeffrey Tang <[email protected]>
…explorer

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/mirror_node.ts
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas requested review from leninmehedy and a team as code owners January 22, 2025 15:50
@JeffreyDallas JeffreyDallas self-assigned this Jan 22, 2025
@JeffreyDallas JeffreyDallas marked this pull request as draft January 22, 2025 15:50
Copy link
Contributor

github-actions bot commented Jan 22, 2025

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   4s ⏱️ -1s
233 tests ±0  233 ✅ ±0  0 💤 ±0  0 ❌ ±0 
238 runs  ±0  238 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 087f580. ± Comparison against base commit 9d1a8cb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 22, 2025

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   13s ⏱️ ±0s
233 tests ±0  233 ✅ ±0  0 💤 ±0  0 ❌ ±0 
238 runs  ±0  238 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 087f580. ± Comparison against base commit 9d1a8cb.

♻️ This comment has been updated with latest results.

Base automatically changed from 01081-D-explorer to main January 22, 2025 16:38
Copy link
Contributor

github-actions bot commented Jan 22, 2025

E2E Test Report

 17 files  126 suites   1h 28m 47s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs  269 ✅ 0 💤 0 ❌

Results for commit 6972ce9.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.36% (target: -1.00%) 78.45%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (89c557a) 21412 17873 83.47%
Head commit (de5e04f) 21789 (+377) 18266 (+393) 83.83% (+0.36%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1196) 566 444 78.45%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codacy-production bot commented Jan 22, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 97.01%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9d1a8cb) 21735 18203 83.75%
Head commit (6972ce9) 21806 (+71) 18265 (+62) 83.76% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1196) 67 65 97.01%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 92.53731% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (0887fa6) to head (6972ce9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/explorer.ts 81.48% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
- Coverage   82.98%   82.87%   -0.11%     
==========================================
  Files          78       78              
  Lines       21746    21806      +60     
  Branches     1851     1528     -323     
==========================================
+ Hits        18046    18072      +26     
- Misses       3566     3666     +100     
+ Partials      134       68      -66     
Files with missing lines Coverage Δ
src/commands/flags.ts 75.96% <100.00%> (+0.31%) ⬆️
src/commands/mirror_node.ts 76.11% <100.00%> (+0.45%) ⬆️
src/core/k8.ts 85.37% <100.00%> (+0.05%) ⬆️
src/commands/explorer.ts 73.15% <81.48%> (-3.32%) ⬇️

... and 35 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/explorer.ts
…mirror-proxy

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/commands/explorer.ts
Signed-off-by: Jeffrey Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Solo to add CLI flags Mirror Node to enable ingress and pass in reserved static IP addresses
1 participant