Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: CE-556 Add partition parameter to API endpoint docs #21374

Merged
merged 11 commits into from
Jul 18, 2024
Merged

Conversation

aimeeu
Copy link
Contributor

@aimeeu aimeeu commented Jun 26, 2024

Description

Many API docs are missing the partition parameter when compared to the corresponding CLI command.

  • Rename existing partition partial to make it clear that it is used in the CLI content.
  • Create new partials for use in the API content.
  • Update API content. I searched the CLI content for files that contained the partition partial and then updated the corresponding API content.

I tested several of the API calls to make sure partition worked as a query parameter or a body key as appropriate.

Deploy preview

Testing & Reproduction steps

None

Links

CD-556

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

aimeeu added 6 commits June 24, 2024 14:03
Update CLI pages for partial rename

API: Add partial for partition as body option
API: Add partial for partition as query parameter

Update API peering and members pages
Update partition partials to be generic
@aimeeu aimeeu added type/docs Documentation needs to be created/updated/clarified pr/do-not-merge PR cannot be merged in its current form. labels Jun 26, 2024
@aimeeu aimeeu requested a review from a team as a code owner June 26, 2024 20:40
@aimeeu aimeeu marked this pull request as draft June 26, 2024 20:40
Copy link

hashicorp-cla-app bot commented Jun 26, 2024

CLA assistant check
All committers have signed the CLA.

@aimeeu aimeeu removed the pr/do-not-merge PR cannot be merged in its current form. label Jul 15, 2024
@aimeeu aimeeu marked this pull request as ready for review July 15, 2024 20:09
@aimeeu aimeeu added the pr/no-changelog PR does not need a corresponding .changelog entry label Jul 15, 2024
@boruszak boruszak added the backport/1.19 This release series is longer active on CE, use backport/ent/1.19 label Jul 15, 2024
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far! Minor phrasing adjustment on the partials.

I'm using the deployment preview to navigate, and it looks like some spots where the partial should go don't have it. For example, Create ACL Auth Method is missing the partial from its query parameters. But the CLI docs confirm that this section should list the partition.

I'm not certain why your search didn't catch these, but it should be a simple copy/paste of the query parameters partial.

Fix headings indent in a few files.
@aimeeu
Copy link
Contributor Author

aimeeu commented Jul 17, 2024

I'm using the deployment preview to navigate, and it looks like some spots where the partial should go don't have it. For example, Create ACL Auth Method is missing the partial from its query parameters. But the CLI docs confirm that this section should list the partition.

@boruszak In the Create ACL Auth Method, I put Partition in the body options because the CLI parms map to API request body options. For example:

image

IIRC, in most cases, PUT and POST contain payloads whereas GET contains query parameters.

Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aimeeu! I was reviewing based off the initial stakeholder request, which called out missing "query parameters" - I'm thrilled that you went the extra step to interpolate those instructions with the methods.

Approved! Merge whenever you're ready!

website/content/api-docs/acl/auth-methods.mdx Outdated Show resolved Hide resolved
@aimeeu aimeeu merged commit 654528c into main Jul 18, 2024
59 checks passed
@aimeeu aimeeu deleted the docs-CE556 branch July 18, 2024 17:02
@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

27 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.19 This release series is longer active on CE, use backport/ent/1.19 pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants