-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: CE-556 Add partition parameter to API endpoint docs #21374
Conversation
Update CLI pages for partial rename API: Add partial for partition as body option API: Add partial for partition as query parameter Update API peering and members pages
Update partition partials to be generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far! Minor phrasing adjustment on the partials.
I'm using the deployment preview to navigate, and it looks like some spots where the partial should go don't have it. For example, Create ACL Auth Method is missing the partial from its query parameters. But the CLI docs confirm that this section should list the partition.
I'm not certain why your search didn't catch these, but it should be a simple copy/paste of the query parameters partial.
Co-authored-by: Jeff Boruszak <[email protected]>
Fix headings indent in a few files.
@boruszak In the Create ACL Auth Method, I put IIRC, in most cases, PUT and POST contain payloads whereas GET contains query parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aimeeu! I was reviewing based off the initial stakeholder request, which called out missing "query parameters" - I'm thrilled that you went the extra step to interpolate those instructions with the methods.
Approved! Merge whenever you're ready!
Co-authored-by: Jeff Boruszak <[email protected]>
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
27 similar comments
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
@aimeeu, a backport is missing for this PR [21374] for versions [1.15] please perform the backport manually and add the following snippet to your backport PR description:
|
Description
Many API docs are missing the
partition
parameter when compared to the corresponding CLI command.partition
partial to make it clear that it is used in the CLI content.partition
partial and then updated the corresponding API content.I tested several of the API calls to make sure partition worked as a query parameter or a body key as appropriate.
Deploy preview
Testing & Reproduction steps
None
Links
CD-556
PR Checklist