Fix pattern comparison on windows #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses filepath.ToSlash to ensure all paths use forward seperators if on Windows. The example `header_ignore` paths all use unix line endings which work fine so long as the paths compared are using unix path seperators. If this is run on Windows, filepath.Walk returns paths with Windows path seperators, which will appear different to doublestar.Match. It's safe to convert \ to / in place in this scenario, as these are valid paths.
dlaguerta
approved these changes
Feb 7, 2023
CalebAlbers
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Thanks a ton, @jpogran! I'll get this out in a release ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses filepath.ToSlash to ensure all paths use forward seperators if on Windows.
🛠️ Description
The example
header_ignorepaths all use unix line endings which work fine so long as the paths compared are using unix path seperators. If this is run on Windows, filepath.Walk returns paths with Windows path seperators, which will appear different to doublestar.Match. It's safe to convert \ to / in place in this scenario, as these are valid paths.🔗 External Links
👍 Definition of Done
🤔 Can be merged upon approval?
✅