Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsm: fix bug in snapshot restore for removed timetable #24412

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Commits on Nov 9, 2024

  1. fsm: fix bug in snapshot restore for removed timetable

    When we removed the time table in #24112 we introduced a bug where if a previous
    version of Nomad had written a time table entry, we'd return from the restore
    loop early and never load the rest of the FSM. This will result in a mostly or
    partially wiped state for that Nomad node, which would then be out of sync with
    its peers (which would also have the same problem on upgrade).
    
    The bug only occurs when the FSM is being restored from snapshot, which isn't
    the case if you test with a server that's only written Raft logs and not
    snapshotted them.
    
    While fixing this bug, we still need to ensure we're reading the time table
    entries even if we're throwing them away, so that we move the snapshot reader
    along to the next full entry.
    
    Fixes: #24411
    tgross committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    a67fc1f View commit details
    Browse the repository at this point in the history