A number of rkt fixes #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achanda
force-pushed
the
b-rkt
branch
2 times, most recently
from
869f7a3 to
90ec377
Compare
achanda
force-pushed
the
b-rkt
branch
7 times, most recently
from
150ddfd to
58a85f0
Compare
|
Right now, these tests run fine on my dev box. I can also run a small job on rkt. Still trying to figure out why the tests are failing on travis. |
achanda
force-pushed
the
b-rkt
branch
14 times, most recently
from
e922607 to
ba75ebd
Compare
achanda
force-pushed
the
b-rkt
branch
2 times, most recently
from
c3d01fc to
7b11da6
Compare
| } | ||
| h.waitCh <- cstructs.NewWaitResult(code, 0, err) | ||
| h.waitCh <- &cstructs.WaitResult{ExitCode: ps.ExitCode, Signal: 0, Err: err} |
achanda
force-pushed
the
b-rkt
branch
3 times, most recently
from
15c1b81 to
1ae0921
Compare
host volumes are the preferred way to share data.
- Reorder rkt arguments to make it work - Change a few things in test
- Introduces a travis target in Makefile to update docker and install rkt
- Removed some unused variables.
Also add a test for mounting alloc dirs
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a number of rkt fixes