Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new-style readme build badges, bump actions/checkout in README.md examples #188

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Add new-style readme build badges, bump actions/checkout in README.md examples #188

merged 3 commits into from
Sep 16, 2022

Conversation

magnetikonline
Copy link
Contributor

@magnetikonline magnetikonline commented Apr 29, 2022

Some quality of life things in README.md:

Copy link
Collaborator

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help with the documentation. This looks great with the exception of the TOC. Your project looks very useful in other contexts, but HashiCorp follows a general format for a README and we don't include a TOC in most cases. This README isn't long enough to warrant one and GitHub already creates anchors for all of the headers to link to.

@magnetikonline
Copy link
Contributor Author

No dramas @jpogran - have rebased and removed be5405d.

@magnetikonline magnetikonline requested a review from jpogran May 19, 2022 07:14
@magnetikonline magnetikonline changed the title Add new-style readme build badges and table of contents Add new-style readme build badges May 20, 2022
@magnetikonline magnetikonline changed the title Add new-style readme build badges Add new-style readme build badges, bump actions/checkout in README.md examples May 24, 2022
@jpogran jpogran merged commit 1f367ab into hashicorp:main Sep 16, 2022
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants