Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore pre-release versions for 'latest' #19

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Ignore pre-release versions for 'latest' #19

merged 2 commits into from
Jun 19, 2020

Conversation

alexjurkiewicz
Copy link
Contributor

No description provided.

@alexjurkiewicz
Copy link
Contributor Author

Fixes #16

@alexjurkiewicz alexjurkiewicz marked this pull request as ready for review June 4, 2020 23:17
@paul-pop
Copy link

paul-pop commented Jun 17, 2020 •
edited
Loading

👋 Is this something that can be merged soon? Probably breaking loads of pipelines because of 0.12 to 0.13 breaking changes.

@kylerjensen
Copy link

@sudomateo 👆

@sudomateo
Copy link
Contributor

Hello. I apologize for the delay here. I've actually transitioned to another team at HashiCorp and I am working with product management to find a new maintainer for this repository since I won't have the bandwidth to maintain this repository going forward. I'll get this merged.

@sudomateo sudomateo merged commit 70ec494 into hashicorp:master Jun 19, 2020
@alexjurkiewicz alexjurkiewicz deleted the ignore-prerelease branch June 19, 2020 00:16
@alexjurkiewicz
Copy link
Contributor Author

Thanks for your time spent on the TF actions! It's great to have canonical solutions for this sort of thing.

honkfestival added a commit to CovidShield/server that referenced this pull request Jun 26, 2020
@honkfestival
Specify a pre-release version (0.13.0) for now.
d9c9dd8 
Hashicorp merged a pull request on June 19th that prevents GitHub
actions without a pinned version from using pre-release versions
(i.e. 0.13.0 as of this writing):

hashicorp/setup-terraform#19

However, this run appears to have used 0.13.0 before it was merged:

https://github.com/CovidShield/server/runs/786126855

I think we can still use the prerelease version if we specify it
explicitly.
@honkfestival honkfestival mentioned this pull request Jun 26, 2020
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sudomateo sudomateo sudomateo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexjurkiewicz @paul-pop @kylerjensen @sudomateo